Re: Please post real patches (Was: [gui][patch] fix jcomponentaction reset)

[Andrew Haley <aph at redhat dot com>]

Mark Wielaard writes:

 > 
 > On Sun, 2004-09-05 at 12:36, Andrew Haley wrote:
 > > Mark Wielaard writes:
 > > 
 > >  > >    public void resetKeyboardActions()
 > >  > >    {
 > >  > > +    if (inputMap_whenFocused != null)
 > >  > >      inputMap_whenFocused.clear();
 > >  > > +    if (inputMap_whenAncestorOfFocused != null)
 > >  > >      inputMap_whenAncestorOfFocused.clear();
 > >  > > +    if (inputMap_whenInFocusedWindow != null)
 > >  > >      inputMap_whenInFocusedWindow.clear();
 > >  > > +    if (actionMap != null)
 > >  > >      actionMap.clear();
 > >  > >    }
 > >  > Please just post what you commit and not some approximation.
 > > 
 > > FWIW, I prefer the form without whitespace diffs for patch approval.
 > > It's vastly easier to see what has been changed.
 > > 
 > > Really, this is a matter of what the patch is for.
 > 
 > Yes, but in that case it should at least be mentioned that the patch
 > isn't for applying.  And the above would not be approved normally since
 > the indentation is completely wrong.

Well, that's an interesting point.  But as an approver I would assume
that 1: the submitter wants to make the patch as easy to read as
possible, and 2: even if the patch doesn't have correct indentation,
the committed code will have.

 > I always assume the patches posted are what is intended to be committed.

I seem to be questioning that assumption.

 > Since we are merging between different code bases constantly and we
 > are (unfortunately) using CVS which isn't that practical when doing
 > merges

Well, I've done that quite a lot.  It's not ideal, but neither is it
impractical.

 > (especially between repositories or when you are not online or have
 > a slow connection to the central repository).

I have never been in that situation.  Praise be.  :-)

 > So lets make sure that what is posted is exactly as what is
 > intended to be committed to the different trees.

As maintainer, you have the right to demand patches in any reasonable
form, and it's important for us to reduce the load on you.  So, you
will get what you want.

I suppose the big difference is that I very rarely apply other
people's patches, but I do read them a great deal.

Andrew.