Re: Please post real patches (Was: [gui][patch] fix jcomponentaction reset)

[Mark Wielaard <mark at klomp dot org>]

Hi,

On Sun, 2004-09-05 at 12:36, Andrew Haley wrote:
> Mark Wielaard writes:
> 
>  > >    public void resetKeyboardActions()
>  > >    {
>  > > +    if (inputMap_whenFocused != null)
>  > >      inputMap_whenFocused.clear();
>  > > +    if (inputMap_whenAncestorOfFocused != null)
>  > >      inputMap_whenAncestorOfFocused.clear();
>  > > +    if (inputMap_whenInFocusedWindow != null)
>  > >      inputMap_whenInFocusedWindow.clear();
>  > > +    if (actionMap != null)
>  > >      actionMap.clear();
>  > >    }
>  > Please just post what you commit and not some approximation.
> 
> FWIW, I prefer the form without whitespace diffs for patch approval.
> It's vastly easier to see what has been changed.
> 
> Really, this is a matter of what the patch is for.

Yes, but in that case it should at least be mentioned that the patch
isn't for applying.  And the above would not be approved normally since
the indentation is completely wrong.

I always assume the patches posted are what is intended to be committed.
Since we are merging between different code bases constantly and we are
(unfortunately) using CVS which isn't that practical when doing merges
(especially between repositories or when you are not online or have a
slow connection to the central repository). So lets make sure that what
is posted is exactly as what is intended to be committed to the
different trees.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part