This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi, Please don't post patches like this if it is not absolutely necessary or at least add a big comment to the patch that it is not the real patch! > public void resetKeyboardActions() > { > + if (inputMap_whenFocused != null) > inputMap_whenFocused.clear(); > + if (inputMap_whenAncestorOfFocused != null) > inputMap_whenAncestorOfFocused.clear(); > + if (inputMap_whenInFocusedWindow != null) > inputMap_whenInFocusedWindow.clear(); > + if (actionMap != null) > actionMap.clear(); > } That is not the patch you are actually committing to the tree! Somehow all white space got stripped. That makes applying the patch either impossible or leads to the wrong result in the tree. Having patches in this format makes merging these changes into another branch or to/from GNU Classpath really hard. In the best case miss some of the indentation, or I use other indentation than the patch submitter. In the worst case it doesn't apply and I have to hunt down some remote code repository to get the actualy patch or do the merge completely by hand. Please just post what you commit and not some approximation. Thanks, Mark
Attachment:
signature.asc
Description: This is a digitally signed message part
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |