Re: [patch] jacks xfails and tclsh

[Andreas Tobler <toa at pop dot agri dot ch>]

Andreas Tobler wrote:

> Tom Tromey wrote:
>
> > > > > > > "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
>
>
> > Sounds good.  Just one nit...
> >
> > Andreas> +    if {[catch {exec tclsh$tcl_ver jacks gcj} msg]} {
> > Andreas> +    send_log "Couldn't run jacks: $msg\n"
> > Andreas> +    return
> >
> > I think the exec will always fail, since we don't pass all the tests.
> > So the `return' is misplaced and perhaps the send_log message could be
> > reworded a little.
>
>
> Ah, after a coffee I understand the sentence. Yesterday I didn't realize 
> that it was addressed to me (irc).
>
> Ok, I verify and adapt. Unfortunately I need another build since last 
> night's build went bad. (my bad).

Ok, confused.

When I said I tested it on darwin and ppclinux I meant I ran the 
complete libjava suite including all tests. And I saw jacks results.
If we would always fail execing the script I would not see jacks results.
I do not see the "Couldn't run jacks ..." msg so I assume that we do not 
fail this way.
Also, why do you say we do not pass all tests? This is done, afaik, with 
setting the vars like this:

set tcltest::testConstraints(assert) 1

Andreas