This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [patch] jacks xfails and tclsh
>>>>> "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
Andreas> I have chosen send_log iso verbose since verbose comes only
Andreas> into the game if you pass it to the RUNTESTFLAGS. Send_log
Andreas> always writes to the libjava.log if something goes wrong.
Sounds good. Just one nit...
Andreas> + if {[catch {exec tclsh$tcl_ver jacks gcj} msg]} {
Andreas> + send_log "Couldn't run jacks: $msg\n"
Andreas> + return
I think the exec will always fail, since we don't pass all the tests.
So the `return' is misplaced and perhaps the send_log message could be
reworded a little.
Tom