This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] jacks xfails and tclsh


Tom Tromey wrote:

"Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:

Sounds good. Just one nit...

Andreas> +    if {[catch {exec tclsh$tcl_ver jacks gcj} msg]} {
Andreas> +	send_log "Couldn't run jacks: $msg\n"
Andreas> +	return

I think the exec will always fail, since we don't pass all the tests.
So the `return' is misplaced and perhaps the send_log message could be
reworded a little.

Ah, after a coffee I understand the sentence. Yesterday I didn't realize that it was addressed to me (irc).


Ok, I verify and adapt. Unfortunately I need another build since last night's build went bad. (my bad).

Thanks,
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]