This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: Patch: pkgconfig usage


On Mon, 2004-02-02 at 01:27, Michael Koch wrote:
> On Sun, Feb 01, 2004 at 09:09:22PM -0500, Thomas Fitzsimmons wrote:
> > On Fri, 2004-01-30 at 10:58, Michael Koch wrote:
> > > On Fri, Jan 30, 2004 at 08:41:55AM -0700, Tom Tromey wrote:
> > > > >>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
> > > > 
> > > > Michael> I write a little patch to use pkg-config in our configure to
> > > > Michael> check for GTK and libart.
> > > > Michael> Okay to commit to trunk ?
> > > > 
> > > > I think we need to check in pkg.m4 if we're going to do this.
> > > > It is convenient if people not on Linux can update configure without
> > > > needing too many other packages installed.  Also it is important that
> > > > we all use the same versions of these files, to minimize configure
> > > > diffs when different developers run autoconf.
> > > 
> > > Okay, I will check that in with the patch.
> > > 
> > 
> > The pkgconfig patch causes AWT apps to fail on startup with an undefined
> > symbol error for g_thread_init.  I've checked in the following patch to
> > fix the problem.
> 
> Damn, you are right. Mark Wielaard and I solved this in classpath
> yesterday but I totally forgot about libgcj on this issue.
> 
> > +      PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.2 gthread-2.0 >= 2.2)
> 
> The check for glib-2.0 is implicit by the gthread-2.0 and the gtk-2.0
> check and can be removed again.
> 

OK, but please make sure by running an AWT program before committing the
changes.

Thanks,
Tom



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]