gfc_build_addr_expr vs. build_fold_addr_expr{,_with_type}

[Paul Thomas]

Richard,

>
>As less intrusive first step I can bring the fortran variants in line
>with the middle-end ones, especially wrt correctness.  We at least
>should correct these issues.
>
For what it is worth, I applaud your effort - I think that the gfortran 
middle-end should be made completely consistent with the rest of gcc. 
The nature of your proposed patch is such that it should apply 
relatively easily to all and any of the trees; ie. a given 
function/macro is replaced by its rest-of-gcc equivalent. A nagging 
worry that I have is that the gcc middle-end is still not very well 
documented. The majority of the active gfortran developers are not 
full-timers and already find the gfortran variants fairly hard going at 
times (speaking first and foremost for myself, of course!) without 
having to delve deeper into gcc MiddleWorld. That said, I would get on 
with it if I were you.

Cheers

Paul T