This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors

From: Jonathan Wakely <jwakely at redhat dot com>
To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Cc: leon zadorin <leonleon77 at gmail dot com>, François Dumont <frs dot dumont at gmail dot com>
Date: Thu, 26 Sep 2019 14:20:43 +0100
Subject: [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors

Fix data race when _Safe_iterator_base::_M_detach() runs concurrently with
the _Safe_container_base destructor.

	PR libstdc++/91910
	* src/c++11/debug.cc (_Safe_iterator_base::_M_detach()): Load pointer
	atomically and lock the mutex before accessing the sequence.
	(_Safe_iterator_base::_M_reset()): Clear _M_sequence atomically.

Tested x86_64-linux. I plan to commit this to trunk unless somebody
sees a problem with it.

Attachment: patch.txt
Description: Text document

Follow-Ups:
- Re: [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors
  - From: Jonathan Wakely
- Re: [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors
  - From: François Dumont

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]