This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors

From: François Dumont <frs dot dumont at gmail dot com>
To: Jonathan Wakely <jwakely at redhat dot com>, libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Cc: leon zadorin <leonleon77 at gmail dot com>
Date: Fri, 27 Sep 2019 18:07:06 +0200
Subject: Re: [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors
References: <20190926131959.GA3393@redhat.com>

On 9/26/19 3:20 PM, Jonathan Wakely wrote:

Fix data race when _Safe_iterator_base::_M_detach() runs concurrentlywith

the _Safe_container_base destructor.

    PR libstdc++/91910
    * src/c++11/debug.cc (_Safe_iterator_base::_M_detach()): Load pointer
    atomically and lock the mutex before accessing the sequence.
    (_Safe_iterator_base::_M_reset()): Clear _M_sequence atomically.

Tested x86_64-linux. I plan to commit this to trunk unless somebody
sees a problem with it.

Thanks to the additional _M_sequence check in _M_detach_single() thispatch looks good.


François

Follow-Ups:
- Re: [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors
  - From: Jonathan Wakely

References:
- [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]