This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][GSoC] Extend shared_ptr to support arrays
- From: Tim Shen <timshen at google dot com>
- To: Fan You <youfan dot noey at gmail dot com>
- Cc: Jonathan Wakely <jwakely at redhat dot com>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 26 Jun 2015 09:55:35 -0700
- Subject: Re: [PATCH][GSoC] Extend shared_ptr to support arrays
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNkEPsJd4Crx1xtp4ZvJ-xFGJ5aaR8qb+A7aVMi++wKRtw at mail dot gmail dot com> <20150612090414 dot GP12728 at redhat dot com> <CALvpekG4+YxSVz+jm_quo20=2bWYXnkBFrjDyBu6eYXW4YarHQ at mail dot gmail dot com> <20150615093829 dot GA21485 at redhat dot com> <CALvpekE2a8qi8qRjdzsDOi2OCRJw_ccYd1CrL6z68rLFW0fK0g at mail dot gmail dot com> <20150616132839 dot GA13009 at redhat dot com> <CALvpekFiRrz2UHTvGh+aqnkQPdL-Y=O-vRUXhxwVs-Wz+5v-RA at mail dot gmail dot com> <CAG4ZjNnyp7Tax3CU0BAnbR0DSo6Xc+z8S7+3BSkYSyPpUpyu6g at mail dot gmail dot com> <CALvpekEmLhme8=FnRRVX3afpU5LkWyrbsJBzW6S6bPUYtRP=gg at mail dot gmail dot com> <CALvpekF3MfgGxuQcPNc2k9eJ1ZWHOSngDu0OC+oBXnvQs6VzpA at mail dot gmail dot com> <20150625164125 dot GL2856 at redhat dot com> <CALvpekHzWvX=xS+6bAPMzON_9BYcAMJDOPizRx-Be46zBoCHKA at mail dot gmail dot com>
On Thu, Jun 25, 2015 at 11:58 PM, Fan You <youfan.noey@gmail.com> wrote:
> 2015-06-26 0:41 GMT+08:00 Jonathan Wakely <jwakely@redhat.com>:
>> On 22/06/15 01:44 +0800, Fan You wrote:
>>>
>>> Is it a good idea to change _Convertible alias to _Compatible in base.h?
>>
>>
>> I still think there should be almost no changes in shared_ptr_base.h
>
> I've moved all the changes to /experimental/memory, except for
> __libfund{} declaration and enable_shared_from_this_helper.
>
> Patch is attached.
I don't see any obvious problem, except for making element_type public.
We still need to wait for Jon to do the final review.
--
Regards,
Tim Shen