This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][GSoC] Extend shared_ptr to support arrays
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Fan You <youfan dot noey at gmail dot com>
- Cc: Tim Shen <timshen at google dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 25 Jun 2015 17:41:25 +0100
- Subject: Re: [PATCH][GSoC] Extend shared_ptr to support arrays
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNkEPsJd4Crx1xtp4ZvJ-xFGJ5aaR8qb+A7aVMi++wKRtw at mail dot gmail dot com> <20150612090414 dot GP12728 at redhat dot com> <CALvpekG4+YxSVz+jm_quo20=2bWYXnkBFrjDyBu6eYXW4YarHQ at mail dot gmail dot com> <20150615093829 dot GA21485 at redhat dot com> <CALvpekE2a8qi8qRjdzsDOi2OCRJw_ccYd1CrL6z68rLFW0fK0g at mail dot gmail dot com> <20150616132839 dot GA13009 at redhat dot com> <CALvpekFiRrz2UHTvGh+aqnkQPdL-Y=O-vRUXhxwVs-Wz+5v-RA at mail dot gmail dot com> <CAG4ZjNnyp7Tax3CU0BAnbR0DSo6Xc+z8S7+3BSkYSyPpUpyu6g at mail dot gmail dot com> <CALvpekEmLhme8=FnRRVX3afpU5LkWyrbsJBzW6S6bPUYtRP=gg at mail dot gmail dot com> <CALvpekF3MfgGxuQcPNc2k9eJ1ZWHOSngDu0OC+oBXnvQs6VzpA at mail dot gmail dot com>
On 22/06/15 01:44 +0800, Fan You wrote:
Is it a good idea to change _Convertible alias to _Compatible in base.h?
I still think there should be almost no changes in shared_ptr_base.h
The Library Fundamentals TS is _experimental_ and not part of the
standard. If it needs a different helper trait then add a new trait
and use it for experimental::shared_ptr, without changing anything in
std::shared_ptr.
If/when this stuff gets moved from the TS into the standard then we
can consider making these changes to <bits/shared_ptr_base.h>, but
then we can probably drop the __libfund_v1 tag type and just make all
the changes directly.
But until it's in the standard I would really prefer to see these
changes isolated in the include/experimental/ directory.