Re: [PATCH][GSoC] Extend shared_ptr to support arrays

[Fan You <youfan dot noey at gmail dot com>]

2015-06-26 0:41 GMT+08:00 Jonathan Wakely <jwakely@redhat.com>:
> On 22/06/15 01:44 +0800, Fan You wrote:
>>
>> Is it a good idea to change _Convertible alias to _Compatible in base.h?
>
>
> I still think there should be almost no changes in shared_ptr_base.h

I've moved all the changes to /experimental/memory, except for
__libfund{} declaration and enable_shared_from_this_helper.

Patch is attached.

>
> The Library Fundamentals TS is _experimental_ and not part of the
> standard. If it needs a different helper trait then add a new trait
> and use it for experimental::shared_ptr, without changing anything in
> std::shared_ptr.
>
> If/when this stuff gets moved from the TS into the standard then we
> can consider making these changes to <bits/shared_ptr_base.h>, but
> then we can probably drop the __libfund_v1 tag type and just make all
> the changes directly.
>
> But until it's in the standard I would really prefer to see these
> changes isolated in the include/experimental/ directory.
>

Attachment: a
Description: Binary data