This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: libstdc++ and race detectors
On Wed, Jul 14, 2010 at 1:58 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> On 07/14/2010 10:57 AM, Jonathan Wakely wrote:
>> My preference would be to do it like that rather than adding yet
>> another level of indirection to our atomics.
>>
> Agreed. But then I'd like to see a one-line comment at each appearance
> of _GLIBCXX_SYNCHRONIZATION_HAPPENS_* pointing to c++config.
Do you mean that _GLIBCXX_SYNCHRONIZATION_HAPPENS_* should be defined
and explained in ./bits/c++config instead of ext/atomicity.h?
> And a few
> lines in the doc
Which part of doc?
Will it make sense to add links to the actual race detection tools in the doc?
> too would be appreciated, also because normally the
> _GLIBCXX_* macros are set automatically at library build time and this
> case may be different.
>
> Anyway, I think we need also to add the macros to rc_string_base.h,
Right. Will do.
Also, what about bits/locale_classes.h?
void
_M_remove_reference() const throw()
{
if (__gnu_cxx::__exchange_and_add_dispatch(&_M_refcount, -1) ==
1)
{
__try
{ delete this; }
> where everything is in templates without instantiations in the .so - no
> problem - like the shared_ptr case. I think we are going to have
> troubles for some locale classes and also for ios_base::Init::~Init.
no luck indeed, warnings here (if any) will have to be suppressed...
>
> By the way, remember that stylistically the open curly bracket always
> begins a new line.
ok
>
> Paolo.
>
>