This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: libstdc++ and race detectors
On 14 July 2010 10:58, Paolo Carlini wrote:
> On 07/14/2010 10:57 AM, Jonathan Wakely wrote:
>> My preference would be to do it like that rather than adding yet
>> another level of indirection to our atomics.
>>
> Agreed. But then I'd like to see a one-line comment at each appearance
> of _GLIBCXX_SYNCHRONIZATION_HAPPENS_* pointing to c++config. And a few
> lines in the doc too would be appreciated, also because normally the
> _GLIBCXX_* macros are set automatically at library build time and this
> case may be different.
Good point.
> Anyway, I think we need also to add the macros to rc_string_base.h,
> where everything is in templates without instantiations in the .so - no
> problem - like the shared_ptr case. I think we are going to have
> troubles for some locale classes and also for ios_base::Init::~Init.
Yes, to annotate those it would be necessary for users to rebuild the
library for use with race-detectors, which is quite a big task.
> By the way, remember that stylistically the open curly bracket always
> begins a new line.
The style guide is available at
http://gcc.gnu.org/viewcvs/trunk/libstdc%2B%2B-v3/doc/html/manual/source_code_style.html?view=co