This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: libstdc++ and race detectors

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: Kostya Serebryany <kcc at google dot com>
Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, libstdc++ at gcc dot gnu dot org, Julian Seward <jseward at acm dot org>, Bart Van Assche <bvanassche at acm dot org>, "Frank, Matthew I" <matthew dot i dot frank at intel dot com>
Date: Wed, 14 Jul 2010 09:57:29 +0100
Subject: Re: libstdc++ and race detectors
References: <AANLkTim68MweWz6dJkpl4t2Ub6EIlhpgPYas_Gc1WurR@mail.gmail.com> <AANLkTillxMgsSHjFGxFi9gqDhRvp7j0-jluKZLxfZfan@mail.gmail.com> <4C37149A.2050401@oracle.com> <AANLkTilT6PA-OTUllfBahHwCoxMYT_Z19kQNk6yGvaG_@mail.gmail.com> <4C3C5BF8.2050805@oracle.com> <AANLkTikNmQ7jpetsnO5KOgD2LQmglLU8X67Gwr8twW1w@mail.gmail.com> <4C3C79B0.4070703@oracle.com> <AANLkTinWYzsa0wZMoAvXGgFt6emEtVhooRONYbKCx_C9@mail.gmail.com> <AANLkTinguZkC2Itigx3CpG2tuRhkoRSPvBZ9GeYWOGKD@mail.gmail.com> <AANLkTimKWPH1F9TpauoYYAYq-KtVRn565uNkF3p9InCh@mail.gmail.com>

On 14 July 2010 07:31, Kostya Serebryany wrote:
>> Can the macros be put directly here?
> Yes. http://codereview.appspot.com/download/issue1800042_12001.diff
>
>> Is a new function needed?
> Only if it will be used on other cases, which doesn't seem to be the case.

My preference would be to do it like that rather than adding yet
another level of indirection to our atomics.

The shared_ptr refcounts in bits/boost_sp_counted_base.h should be
able to use the same approach for _M_release and _M_weak_release, but
I'm not sure about the compare-and-swap loop in _M_add_ref_lock

Follow-Ups:
- Re: libstdc++ and race detectors
  - From: Jonathan Wakely
- Re: libstdc++ and race detectors
  - From: Paolo Carlini

References:
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Paolo Carlini
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Paolo Carlini
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Paolo Carlini
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Jonathan Wakely
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]