Re: Search algorithms in __gnu_cxx::

[Paolo Carlini <pcarlini at suse dot de>]

Dhruv Matani wrote:

> On 11/14/06, Paolo Carlini <pcarlini@suse.de> wrote:
>
> > Dhruv Matani wrote:
> >
> > > I've patched on gcc-4.2[gcc version 4.2.0 20061107 (prerelease)]
> >
> > ... no way to convince you that we always patch *mainline* first...
>
> I mailed Benjamin explaining to him that I can't seem to be able to
> get mainline from svn, and current 4.3 snapshot. He said that it's
> fine if I am able to test against any 4.2 snapshot.

Sure, in *practice* in this specific case it's fine, because we just 
branched. But, as a general rule, you should *always* patch mainline: if 
you are encountering special problems, you should try to explain in 
detail to the people reading the mailing lists or eventually to the 
overseers.

> Here are the numbers. Attached is the file used.
>
> +-------------------+---------+
> | algo              | time    |
> +-------------------+---------+
> | Boyer Moore       | 9.475s  |
> | std::search       | 12.283s |
> | strstr            | 13.184s |
> | std::string::find | 20.166s |
> +-------------------+---------+

Excellent. Well, the comparison would be easier if you had used the 
performance testcase that *yourself* added some time ago, but anyway, we 
can take care of that double check, no problem. Otherwise, I'm unsure 
that we want to add the new trait to the general ext/traits file, and I 
still believe a separate file would be better (because of the already 
mentioned namespace issue). Otherwise, I think we are quickly converging 
to something we can commit soon, good.

Paolo.