This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Search algorithms in __gnu_cxx::
Dhruv Matani wrote:
I've patched on gcc-4.2[gcc version 4.2.0 20061107 (prerelease)]
... no way to convince you that we always patch *mainline* first...
Please let me know if you have any other specific requirements in mind.
... also no way to convince you that we are in a 64-bits era: I can tell
you immediately that many of your types are wrong, today ints are often
32-bits, you can't assign the difference of two iterators to an int, you
need a difference_type; similarly you cannot assign a size_t to an int,
because a size_t today is often 64-bits...
While you are at it, please consistently uglify *everything*; don't use
curly braces for single statement blocks; follow the conventions about
names of iterator types (from the name must be *obvious* the iterator
category); index excess *128* because the smallest signed (8-bit) char
value is -128. There are many additional minor things, but we have time,
I'd like to see first performance numbers vs current string::find...
Paolo.