This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Run V3 tests on installed compiler


Gabriel Dos Reis wrote:
Mark Mitchell <mark@codesourcery.com> writes:

[...]

| I immediately offered to revert my patch, once you objected.  But, I
| don't feel it discourteous for GWP people to check in changes without
| consulting the C++ maintainership first, so long as they go through
| the usual testing procedures.

A snag is that a GWP is not necessarily someone who knows the
intimate details of every aspect of GCC (nor shall he/she be required
to), which is why consulting with field people before check-in would
have been appreciated. As far as I can see that courtesy had been exercised in the past and I hope that will continue.

I think the choice is roughly between (a) assuming that GWP people will usually do the right thing, and letting them go ahead, so long as they are willing to clean up mistakes promptly, and (b) providing an up-front review opportunity so that mistakes don't make it into the tree. In other words, is speculative execution OK?


I'm comfortable with (a), but I don't have a problem with (b) either, and it's very clear that for V3 (b) is strongly preferred.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]