This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: PATCH: Run V3 tests on installed compiler
> I see that now.
A truly magnanimous apology. Again, I expect more: your behavior is a disappointment.
> I meant "any objections to this follow-on plan?", rather than "any
> objections to this initial patch?"
Yes. Details to follow. I have no objections to your goal, just everything else.
> It should be made clear that the initial patch does *not* do the things
> in the numbered list. As far as I know, the only change that should
> affect V3 testers in the initial patch is that "testsuite_files" is
> ignored, and, instead, its contents are generated dynamically in
> DejaGNU, as is done in other DejaGNU testsuites. At this point,
> testsuite_files is still generated, and, of course, you can pass an
> explicit list of tests to DejaGNU, if you want.
In practice, how do you pass a list of just files in say
testsuite_27/basic_istream? Or testsuite/tr1? Or testsuite/ext? In
practice, it is common for me to run tests on just the part of the
library I'm working on, and then when that works it's on to the whole
schebang. I think testsuite_files is a feature, not a bug.
Current practice is detailed here:
http://gcc.gnu.org/onlinedocs/libstdc++/test.html
Please bother to read it before complete changing things underneath our
feet, without warning. If you're changing current practice, please
update this doc at the same time.
Your current approach makes testing much more difficult IMHO.
A way to repair the damage would be to keep the testsuite_files makefile
rules, not have it run by default, and *if this files exists* (ie
maintainers have run the make rule) use it for the files, if not
generate dynamically. That would allow library maintainers to keep this
more efficient workflow, and allow you to test install as well.
-benjamin