Re: libgcj merging and VMStackWalker

[Mark Wielaard <mark at klomp dot org>]

Hi Tom,

On Sat, 2006-05-13 at 17:41 -0600, Tom Tromey wrote:
> I think this merge could be done fairly simply.  In fact I think it
> just requires adding a 'Class' argument to
> VMStackWalker.getCallingClass and VMStackWalker.getCallingClassLoader.
> This argument would name the immediate caller, and these methods
> would be changed to return the class just above the argument class in
> the stack trace.
> 
> With this change I think I could immediately merge Logger,
> ResourceBundle, Package, and parts of SecurityManager and the little
> CORBA differences.
> 
> I don't think this would overly affect performance (a big worry on the
> gcj end) or maintainability on the Classpath side.
> 
> It would require a small VM change.  However, other VMs could simply
> add this method argument and then ignore it, and things would continue
> to work as they do today.

I like it since this looks like the proposal I made last year. But there
were some (strong) opinions about that change back then. You might want
to read that thread:
http://lists.gnu.org/archive/html/classpath-patches/2005-01/msg00138.html

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part