This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: libgcj merging and VMStackWalker
- From: Andrew Haley <aph at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: GNU Classpath Project <classpath at gnu dot org>, GCJ Hackers <java at gcc dot gnu dot org>
- Date: Mon, 15 May 2006 15:35:14 +0100
- Subject: Re: libgcj merging and VMStackWalker
- References: <m3mzdlsdar.fsf@localhost.localdomain>
Tom Tromey writes:
> This week I spent some time looking at the libgcj/Classpath merge
> situation. After removing all the simple merges that hadn't yet been
> handled for some reason, I looked at VMStackWalker a little.
>
> I think this merge could be done fairly simply. In fact I think it
> just requires adding a 'Class' argument to
> VMStackWalker.getCallingClass and VMStackWalker.getCallingClassLoader.
> This argument would name the immediate caller, and these methods
> would be changed to return the class just above the argument class in
> the stack trace.
I think this is a bug. In the API spec, when the caller is wanted it
is the immediate caller -- the calling method, not the calling class.
We shouldn't be walking backwards until we see a different class.
See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27352.
I think this was my mistake. :-(
Andrew.