This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch] Silence some compiler warnings.
- From: Tom Tromey <tromey at redhat dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Wed, 16 May 2007 19:55:00 -0600
- Subject: Re: [Patch] Silence some compiler warnings.
- References: <464B9D88.1010102@avtrex.com>
- Reply-to: tromey at redhat dot com
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> Some of the C++ files that make up libgcj are generating compiler
David> warnings. This patch silences them, and also removes a dead union
David> definition that I encountered along the way.
David> Tested on x86_64-pc-linux-gnu with no regressions.
David> OK to commit?
Yes, thanks. One little note...
David> - while (! compare_and_swap (&lock, 0, 1));
David> + while (! compare_and_swap (&lock, 0, 1)) ;
In cases like this I prefer the ';' on its own line, to emphasize the
loop's emptiness. Call it "Sartre style".
If you are in a warning-killing mood, Ian pointed out that we have
some overflow warnings to fix. These have the added bonus that they
probably reflect real bugs :-)
Tom