This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Silence some compiler warnings.

From: David Daney <ddaney at avtrex dot com>
To: Keith Seitz <keiths at redhat dot com>
Cc: Java Patch List <java-patches at gcc dot gnu dot org>
Date: Wed, 16 May 2007 17:26:44 -0700
Subject: Re: [Patch] Silence some compiler warnings.
References: <464B9D88.1010102@avtrex.com> <464B9F0B.5030101@redhat.com>

Keith Seitz wrote:

David Daney wrote:
OK to commit?
   * gnu/classpath/jdwp/natVMVirtualMachine.cc (jdwpSingleStepCB):
   Don't declare unused parameter jni_env.
You shouldn't need this one anymore. That should have been silenced by my patch from earlier today:

2007-05-16 Keith Seitz <keiths@redhat.com>
    [snip]
        (jdwpBreakpointCB): If the event list is not empty, send
        whatever events are in it and the breakpoint event in a single
        notification.
-->     Mark parameter jni_env as MAYBE_UNUSED.
    [snip]
Although I see that I marked it as belonging to jdwpBreakpointCB instead of jdwpSingleStepCB...

If the patch is approved, I will of course have to merge it with the current state of the trunk before it can be committed. I will post a final diff if it differs from the original.

David Daney

References:
- [Patch] Silence some compiler warnings.
  - From: David Daney
- Re: [Patch] Silence some compiler warnings.
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]