This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch] Silence some compiler warnings.
- From: Andrew Haley <aph-gcc at littlepinkcloud dot COM>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: David Daney <ddaney at avtrex dot com>, Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Thu, 17 May 2007 10:04:38 +0100
- Subject: Re: [Patch] Silence some compiler warnings.
- References: <464B9D88.1010102@avtrex.com> <m3lkfodxjf.fsf@fleche.redhat.com>
Tom Tromey writes:
> >>>>> "David" == David Daney <ddaney@avtrex.com> writes:
>
> David> Some of the C++ files that make up libgcj are generating compiler
> David> warnings. This patch silences them, and also removes a dead union
> David> definition that I encountered along the way.
> David> Tested on x86_64-pc-linux-gnu with no regressions.
>
> David> OK to commit?
>
> Yes, thanks. One little note...
>
> David> - while (! compare_and_swap (&lock, 0, 1));
> David> + while (! compare_and_swap (&lock, 0, 1)) ;
>
> In cases like this I prefer the ';' on its own line, to emphasize the
> loop's emptiness. Call it "Sartre style".
What is this for? Is it a GNU coding convention, or what?
Andrew.