This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch to remove unused langhooks
- From: Richard Henderson <rth at redhat dot com>
- To: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Sun, 11 Jul 2004 01:44:00 -0700
- Subject: Re: Patch to remove unused langhooks
- References: <Pine.LNX.4.58.0407110033170.2389@digraph.polyomino.org.uk>
On Sun, Jul 11, 2004 at 12:36:43AM +0000, Joseph S. Myers wrote:
> (A further five hooks are used but have a trivial default definition
> and no front ends give them a nondefault definition:
> LANG_HOOKS_SAFE_FROM_P, LANG_HOOKS_TREE_INLINING_START_INLINING,
> LANG_HOOKS_TREE_INLINING_END_INLINING, LANG_HOOKS_TYPE_MAX_SIZE,
> LANG_HOOKS_PREPARE_ASSEMBLE_VARIABLE. One has a nontrivial default
> definition and no front ends give another definition:
> LANG_HOOKS_UNSAVE_EXPR_NOW. Unless there are immediate plans for a
> front end to use them or they specifically exist for the sake of an
> out-of-tree front end - in which case the comments on them should say
> so - I'm inclined to think that they should also cease to be
> langhooks.)
The MAX_SIZE one Kenner added recently. Presumably he's intending
to so something with the ada front end.
SAFE_FROM_P and UNSAVE_EXPR_NOW are part of rtl machinery that
should simply be removed.
Patch is ok.
r~