This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch to remove unused langhooks
- From: Zack Weinberg <zack at codesourcery dot com>
- To: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Thu, 15 Jul 2004 23:28:33 -0700
- Subject: Re: Patch to remove unused langhooks
- References: <Pine.LNX.4.58.0407110033170.2389@digraph.polyomino.org.uk>
"Joseph S. Myers" <jsm@polyomino.org.uk> writes:
> This patch removes six langhooks.
Yay.
I'd like to point out that insert_block really needs to die. The only
remaining use is tree-inline.c::remap_block, inside an #if 1 with a
FIXME comment at the top of it.
Also, it might make sense to give write_global_declarations the same
treatment you gave lhd_clear_binding_stack; along with a little work
to make dbxout.c not need it (see the comment near the end of
dbxout_init), this would allow the removal of the getdecls hook.
Going even further off into it-would-be-nice land, cgraph ought to be
expanded to handle everything that wrapup_global_declarations and
check_global_declarations do, and then we wouldn't need the
write_globals hook at all. (Have I mentioned that calling
cgraph_optimize ought to be the responsibility of language-independent
code?)
zw