Re: Patch: MingW32 3.4 Cleanup / Refactoring / Enhancements

[Michael Koch <konqueror at gmx dot de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 10. Juli 2003 16:49 schrieb Mohan Embar:
> Hi Patch People,
>
> I'm booting this thing out of the nest even though
> I haven't created an exhaustive test for it. (I've
> done pretty decent ad hoc testing and if I don't
> push this out now, I'll procrastinate on this even
> longer. It's an order of magnitude better than what's
> there already - consider it one of those drugs that
> the US Food and Drug Administration rushes to market
> before they've done exhaustive clinical testing....)
>
> See the previous post for an explanation of what this does:
>
> http://gcc.gnu.org/ml/java-patches/2003-q2/msg00567.html
>
> To reiterate: this only touches MingW-specific files.
>
> I've split out Ranjit's os.arch and process quoting patches
> from this one. In a separate post, I'll indicate what
> patches need to be applied to MingW gcj in what order.
>
> With this patch, I believe that the MingW code would show
> a higher degree of JRE conformance than the current POSIX
> net code because some sections are erroneously throwing
> InterruptedIOExceptions instead of SocketTimeoutExceptions.
> I've discussed this with Michael informally, but will follow
> up on this more formally later.
>
> The next thing I'll try to do is right a more exhaustive test
> suite that, while not Mauve-compliant, will be something where
> you can hopefully nicely diff against the JRE output of the same
> test.
>
> I've compressed this because it's 99k unzipped.

I'm for this patch with one point against it: It doenst support the 
configure option --disable-java-net (as Ranjit mentioned earlier). If 
we drop this option for windows this should be visible in the output 
of ./configure --help. I have not compiled libgcj with the patch but 
I think it is okay when Ranjit says its okay. If Ranjit agrees and 
has not more points agains it you can commit it.


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/F++vWSOgCCdjSDsRAkUYAJ91PHtO1Rb8WoFmV1CexNI5iCbe6QCfbxfH
ts9RTL8Iyv9TIhL5WRLEq9k=
=jQ/u
-----END PGP SIGNATURE-----