MingW32 3.4 Cleanup / Refactoring / Enhancements

[Mohan Embar <gnustuff at thisiscool dot com>]

Ranjit and Michael,

Attached is my attempt at cleaning up, refactoring and
enhancing the mingw32 libjava code. This was mostly
inspired by the Posix <-> Win32 network code split,
but while I was in here, I also cleaned up and refactored
some other Win32 stuff too.

Before I formalize this and write up a massive ChangeLog,
I wanted you two to look this over and see if I've done
anything horrifying.

Here is what I attempted to do:

- clean up the networking code somwhat and implement timeouts
- implement NetworkInterface.getRealNetworkInterfaces()
- do general cleanup, eliminate duplicate code,
  standardize error reporting, etc.

I didn't attempt to eliminate all Winsock 1.1 usages.

Ranjit, I also folded in this patch:

http://gcc.gnu.org/ml/java-patches/2003-q2/msg00271.html

Only mingw32-specific files are affected by this. Of
particular interest are the helper functions and classes
I've added to include/win32.h. The Posix folks might
benefit from JStringToCString and JvGetStringUTF too.

Along the way, my text editor converted tabs to spaces and
eliminated trailing spaces, so the patch is basically
unreadable. As such, I've zipped up the patched source
files. I also stuck with the inconsistent, non-compliant
coding style in these source files and didn't attempt to
clean them up.

I am still working on the official tests for these. I've
tested these in an ad-hoc manner but plan to unleash my
build with these changes to the world for further
experimentation.

Let me know what you think.

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/

Attachment: w32c.tar.bz2
Description: application/bzip2