This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch for Preview: Win32 Process Implementation
- From: "Ranjit Mathew" <rmathew4lists at hotmail dot com>
- To: <gnustuff at thisiscool dot com>,<java-patches at gcc dot gnu dot org>
- Date: Tue, 25 Feb 2003 10:45:58 +0530
- Subject: Re: Patch for Preview: Win32 Process Implementation
- References: <WTVJHP73KINLJEFB0ULKZT93QL93.3e5a2e1c@p733>
- Reply-to: "Ranjit Mathew" <rmathew at hotmail dot com>
> >As mentioned earlier, since we want to make Tom's life easier
> >while dealing with our patches, we should submit them in a format
> >that makes it easy for him to directly apply it from within his
> >mailer:
>
> I had looked at your previous post, examined your most-recent
> patch and also the source of clcleanup before posting this.
> As far as I can tell, the patch I submitted contains tabs,
> not spaces. If Tom has any trouble applying this, or if you
> can point out why Tom would have trouble applying this, I
> promise I'll redo the patch.
Sorry, I was not talking about tabs v/s spaces and I was not
asking you to resubmit your patch - I was just saying that the
following embedded ChangeLog entry looked a bit less of work
for Tom:
------------------------------- 8< -------------------------------
Index: ChangeLog
from Mohan Embar <gnustuff at thisiscool dot com>
* java/lang/natWin32Process.cc (java::lang::ConcreteProcess::startProcess):
double-quote each program array element passed to CreateProcess
------------------------------- 8< -------------------------------
than the one in your patch.
*However*, I realised that if your mail is passed through clcleanup first
and then through cl2patch, one gets the correct patch. So it *should not*
be a problem for Tom...
Sorry for the noise...
Ranjit.