This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch for Preview: Win32 Process Implementation
- From: Tom Tromey <tromey at redhat dot com>
- To: gnustuff at thisiscool dot com
- Cc: java-patches at gcc dot gnu dot org
- Date: 01 Mar 2003 15:52:28 -0700
- Subject: Re: Patch for Preview: Win32 Process Implementation
- References: <KJ93IC98FEQOMLXUOIXTSO84USOM4XJE.3e58fc5c@p733>
- Reply-to: tromey at redhat dot com
>>>>> "Mohan" == Mohan Embar <gnustuff at thisiscool dot com> writes:
Mohan> 2003-02-23 Mohan Embar <gnustuff at thisiscool dot com>
This looks good to me. I'm checking it in to the trunk and the 3.3
branch.
It is small enough, imho, not to need paperwork. However, future
patches will.
A couple trivial nits to pick:
Mohan> * java/lang/natWin32Process.cc (java::lang::ConcreteProcess::startProcess):
Mohan> double-quote each program array element passed to CreateProcess
In the ChangeLog entry, just put the function name in the parens.
Usually, in libgcj, there's no need to spell out the full class name.
Mohan> + if (i>0)
You need spaces around the `>'.
Tom