This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
RE: Patch for Review: PR/9254 and other Win32 Threading Fixes
- From: "Boehm, Hans" <hans_boehm at hp dot com>
- To: "'Adam Megacz'" <gcj at lists dot megacz dot com>, Ranjit Mathew <rmathew at hotmail dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Tue, 28 Jan 2003 14:47:53 -0800
- Subject: RE: Patch for Review: PR/9254 and other Win32 Threading Fixes
It looks fine to me, too.
If someone wants to further tune this, it looks to me like the EnterCriticalSection and LeaveCriticalSection calls could be avoided for nested lock acquisitions, as they are in the Posix case. It seems that the fact that EnterCriticalSection is already reentrant doesn't really buy you anything, and you'd be better off pretending it weren't. Probably Adam's suggestion to migrate more of this into the platform-independent code is right.
Hans
> -----Original Message-----
> From: Adam Megacz [mailto:gcj@lists.megacz.com]
> Sent: Tuesday, January 28, 2003 12:11 PM
> To: Ranjit Mathew
> Cc: java-patches@gcc.gnu.org
> Subject: Re: Patch for Review: PR/9254 and other Win32 Threading Fixes
>
>
>
> Looks good to me.
>
> - a
>
>