Re: Patch for Review: PR/9254 and other Win32 Threading Fixes

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Ranjit" == Ranjit Mathew <rmathew@hotmail.com> writes:

Ranjit> Sorry! (And Tom would also chide me for not including a "Fixes
Ranjit> PR java/9254" in the ChangeLog - Sorry again!)

This particular patch didn't apply cleanly.  I don't know why, but in
the end I had to do some hand editing, which is a pain.  I double
checked my work, but the potential for error still remains.  Could you
check too?

Let me wax pedantic for a few moments.

In a ChangeLog entry, before each line is a tab, not some number of
spaces.  That's pretty pedantic, I know, but I always notice it
instantly due to Emacs font-lock.  I've been making this change before
checking in your changes, but hopefully it wouldn't be hard for you to
change this before submitting.

Finally, the particular format you've been using to submit patches is
one of the most difficult ones for me to deal with.  I have to edit
your message before I can apply the patch.  I'd find it *much* more
convenient if the ChangeLog entry run through `clcleanup' first, or
even if it were just part of the patch.  As it is, if I use my
mailer's key binding to directly apply your patch, I wind up with the
whole patch in the ChangeLog (as we saw with a fastjar patch last
week, bleah).

Ranjit> Submitting this (yet) again after incorporating Hans's feedback:

Adam said this was ok.  I also read through it and it seems
reasonable.  So I'm putting it in 3.3 and the 

Tom