This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Git ChangeLog policy for GCC Testsuite inquiry
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Jeff Law <law at redhat dot com>
- Cc: Richard Sandiford <richard dot sandiford at arm dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, paul at mad-scientist dot net, GCC Development <gcc at gcc dot gnu dot org>
- Date: Thu, 6 Feb 2020 07:51:01 -0600
- Subject: Re: Git ChangeLog policy for GCC Testsuite inquiry
- References: <0829cb62791e9d8d034309f09b6c911ed8340c8b.camel@redhat.com> <1693150.uSzEE5ffML@polaris> <df5a09ce54d07c7bb60b4e00b76e7b4673779333.camel@redhat.com> <20200124214533.GB17695@tucnak> <bd1de829b095c5037804dd162989b8d398ef8b01.camel@mad-scientist.net> <CAMe9rOrJQTv-9R1HTSk3w=J2e-1wZd4vd=xEWQaL8hFCnj_qAQ@mail.gmail.com> <mptpnev4i2a.fsf@arm.com> <6bc259050138912ea9b973ca4f43df72cb1bb7d8.camel@redhat.com> <20200205211801.GV22482@gate.crashing.org> <7743417118d2067cf0e9e1b840564f9f2d5e72dc.camel@redhat.com>
On Wed, Feb 05, 2020 at 06:43:54PM -0700, Jeff Law wrote:
> On Wed, 2020-02-05 at 15:18 -0600, Segher Boessenkool wrote:
> > As a reviewer, the changelog is priceless still. We shouldn't drop the
> > changelog before people write *good* commit messages (and we are still
> > quite far from that goal).
> I believe the current proposal is not to switch immediately, but to do
> so after gcc-10 is released. Feel free to suggest improvements to
> ChangeLogs or summaries in the mean time to get folks to start
> rethinking what they write in 'em.
I think I will be quite busy until the end of stage 4 already, but sure,
of course I will not shut up.
> And FWIW, we're talking about the ChangeLog *file* here.
I don't think we were. I have absolutely nothing against only putting
the changelog entries at the end of the commit message and extracting
that later, of course (although it is almost trivial to copy it to the
changelog files manually, I have the same workflow for it as when we
still committed with SVN, just "git am" instead of more clunky stuff,
I suspect it will streamline things, esp. for new people).
> If folks
> continued writing the same log messages and put them into git, I
> personally think that's sufficient to transition away from having a
> ChangeLog file in the source tree.
Sure. Just needs a flag day, always painful, but it will help.
> I don't want to make perfect the enemy of the very very good here and
> moving away from a ChangeLog file in the source tree is, IMHO, very
> very good.
If you rebase changelog files, then yes, it's a bloody pain ;-)
Segher