This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"


On 23/01/2020 15:28, Jakub Jelinek wrote:
On Thu, Jan 23, 2020 at 04:23:01PM +0100, Thomas Schwinge wrote:
Hi!

On 2020-01-23T12:46:24+0000, Andrew Stubbs <ams@codesourcery.com> wrote:
I've committed this patch to fix a bug in the OpenMP argument parsing.

<https://gcc.gnu.org/g:14e5e74698b98f4cbe398cb989dfa27765cbca6e>.

Why did "the system" decided to annotate <https://gcc.gnu.org/PR2020>?
For obvious reasons, there are "2020" references in this commit, but
nothing with a "PR" or "PR [...]/" prefix.

Thus, some problem in GCC's Git/Bugzilla hooks?

I think it also recognizes bug NNNN and matches any whitespace in between
the bug and word and number.  The commit message has:
.................................................... bug

2020-

Perhaps we should match only at most one newline (but that is non-fun with
the various Unix/MSDOS/MacOS line endings), or not match if the number is
followed by - without whitespace?

	Jakub


Perhaps we should restrict that to a single line, ie only horizontal white space. Our commit style isn't really that free-form when citing bugs. Or perhaps require [:.]?\w after the number (ie an optional period or colon and then some white space).

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]