Re: lno-branch vs ptr-to-member

[Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>]

Hello,

> > >> I'm not familiar enough with ptr-to-member to figure out what it ought
> > >> to be doing,
> > >> but this isn't it.
> > >
> > > neither do I.  From what you describe it seems that chrec_convert
> > > decides that it does not know anything special to do with the 
> > > conversion (which
> > > is OK) and just passes it to convert (which seems OK to me), which 
> > > probably
> > > should be able to handle it somehow (the other possibility being that
> > > the gimplified code is wrong).
> > 
> > OK, I guess we need help from the experts in those areas to tell which
> > of these is true.  I'll try working around it by not trying to do this 
> > particular
> > conversion, but I tend to agree that's not the right fix.
> > 
> > This is PR 15881.
> 
> Calling convert from the middle-end is asking for troubles.

interesting; we do it moreorless everwhere (dom, sra, ccp, ...).

> One it creates non-gimple,

Why should this be a problem (as long as you know about it)?

> two it prints out error message which is bad for the middle.

Yes, this seems worse.

> I posted a patch to change all of the convert to fold_convert in tree-scalar-evolution.c
> at <http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00460.html>.

Feel free to install the patch.  Thanks.

Zdenek

> This fixes
> this error as I had changed fold_convert to treat OFFSET_TYPE to be just like
> POINTER_TYPE, see <http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00458.html>.
> 
> Thanks,
> Andrew Pinski