Re: gcc 3.4.0 m68k-elf generates illegal code for ColdFire (maybea fix)

[Bernardo Innocenti <bernie at develer dot com>]

Peter Jakubek wrote:
> Bernardo Innocenti wrote:
>
> > peter@lasergraph-dsp.de wrote:
> >
> > I'm not qualified to review your patch, sorry.  I could run
> > regression tests for your patch.  Is there a PR already on file?
>
>
> My problem report is here:
> http://gcc.gnu.org/ml/gcc/2004-05/msg01263.html
>
> As Peter Barada pointed out this is actually an old issue that was
> reported by others (long) before I did:
> http://gcc.gnu.org/ml/gcc/2004-05/msg01264.html

Oh, yeah... PR8309.  I've reopened it myself a few
days ago.

Let's wait for a review from a senior maintainer then...


> I think my patch fixes this issue. Peter (Barada), did it work for
> you too?

I'm confident your patch fixes the issue, but since it
touches common code for all big-endian targets, I'd
prefer to run regression tests to see if it can have
unwanted side-effects.


> > A slightly different version of this patch just went in CVS today.
> >
> > It was credited to Peter Barada, but now I wonder wether you've
> > both developed the same patch independently or I should add your
> > name in the ChangeLog entry.
>
> I sent my patch to Peter Barada first, because it seems he is most
> actively taking care of the ColdFire port. He improved the patch
> by using moveq if possible and then and submited it to the gcc list.
> That's fine with me.

I've also added your name in the ChangeLog.  When patches
are being reworked by multiple people, all them get named,
so we can blame them all when something wrong happens ;-)

--
 // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/