This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Illegible dumps with dump_cfg_function_to_file
On Fri, 2003-11-07 at 09:38, Zdenek Dvorak wrote:
> OK, but IMHO the right way is what dump_cfg_function_to_file does, since
> it is infrastructure independent. dump_function_to_file is only useful
> before we switch to cfg based representation.
>
The point still stands. Let's not have 2 function dumpers. Just one
that is smart enough to tell whether to use the CFG based representation
or the original tree linkage. The pretty printer already knows how to
dump basic block information, PHIs and VOPs. It's not necessary to
duplicate that.
Let's just move the bb traversal code from dump_cfg_function_to_file
into dump_function_to_file and add smarts to dump_function_to_file to
determine when to switch between dumping DECL_SAVED_TREE(fndecl) and
traversing the basic blocks.
> I have sent a fix for this together with the cfg-aware
> remove_useless_... patch (I may send it as a separate patch if you
> prefer).
>
Yes, please. One functionality change per-patch. It's easier to review
that way.
Diego.