This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Illegible dumps with dump_cfg_function_to_file
On Fri, 2003-11-07 at 03:31, Zdenek Dvorak wrote:
> > Why did you introduce this new function instead of using
> > dump_function_to_file?
>
> Because it no longer works after cfg creation (or perhaps it does just
> now, but will not quite soon, and it anyway seems better to me to use
> an intermediate-represenation independent solution).
>
Which is what dump_function_to_file should be. To get consistent
visuals, we need to have a single point of entry to the dumpers.
dump_function_to_file should be able to tell whether the function has
been hacked into basic blocks. We should not have two different
function dumpers. There's going to be code duplication problems and
visual consistency problems, making it hard to diff between different
passes.
There's something else wrong with dump_cfg_function_to_file. It is not
guaranteed to dump the function in program order. It should walk down
the dominator tree, not traverse the blocks linearly.
dump_cfg_function_to_file must disappear. Its functionality should be
included in dump_function_to_file.
Diego.