This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Gcc 3.3 regressions

On Sep 17, 2003, "H. J. Lu" <> wrote:

> FAIL: gcc.dg/pack-test-2.c  (test for errors, line 6)

> Alexandre, they may have something to do with your patches.

They do.  It's apparently the same problem that caused regressions on
Darwin in mainline.  I thought -Wunknown-pragmas would have triggered
the same path, and was convinced my patch would fix it, but it turns
out I was wrong: pragmas for which a handler is defined don't get the
pfile->directive_line that do_pragma() passes to def_pragma.
def_pragma sets lineno to that line and then calls the diagnostic
function, whereas none of the direct handlers do.

I'm currently inclined to reintroduce the cb_line_change, but passing
it false, like destringize_and_run() in the same file, and to do so
right after we read the first pragma token name, or even before doing
so, such that we don't have to pass pfile->directive_line to the
cb_def_pragma, and all pragma handlers will have the correct line
numbers already set up.  How's that?

Alexandre Oliva   Enjoy Guarana', see
Red Hat GCC Developer                 aoliva@{,}
CS PhD student at IC-Unicamp        oliva@{,}
Free Software Evangelist                Professional serial bug killer

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]