Re: Patches to C++ front end have caused numerous regressions

[Jan Hubicka <jh at suse dot cz>]

> On Fri, 2003-09-12 at 13:47, David Edelsohn wrote:
> > >>>>> Mark Mitchell writes:
> > 
> > Mark> The problem seem to include missing constructors and destructors, and
> > Mark> internal errors in cgraph_finalize_function.
> > 
> > Mark> I will revert the patches causing these problems under the 48-hour
> > Mark> rule if the problems are not corrected by then.
> > 
> > 	What patches are you proposing to revert?  I think that we need to
> > push forward and get this feature working when Honza gets back from his
> > trip.  I would much rather see the backlog of patches reviewed than
> > causing even more instability by reverting patches.
> 
> I will revert all of the recent patches that have caused regressions,
> until we get back to a pre-regression state.  The obvious candidates
> are:
> 
> 2003-09-11  David Edelsohn  <edelsohn@gnu.org>
> 
> 	* decl2.c (var_finalized_p): Swap arms of conditional.
> 
> 2003-09-10  Jan Hubicka  <jh@suse.cz>
> 
> 	* decl2.c (var_finalized_p): New.
> 	(maybe_emit_vtables, write_out_vars, finish_file): Use it.
> 
> If Honza is on vacation, then this is an additional argument for
> reverting these patches.

Mark, I am very syre that after var_finalized_p testing there were no
such faiulres on my x86 testing.  In fact I never seen them (my last
testusite run before leaving still does not show that) so i guess
it can be conflict of two different patches tested and commited in
parallel or something like that...

Honza