This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Patch to decl2.c
- From: Mark Mitchell <mark at codesourcery dot com>
- To: geoffk at apple dot com, rth at redhat dot com
- Cc: gcc at gcc dot gnu dot org
- Date: 05 Sep 2003 09:34:13 -0700
- Subject: Patch to decl2.c
Geoff, Richard --
Shouldn't this patch be reverted?
2003-09-02 Geoffrey Keating <geoffk@apple.com>
PR 12161
* decl2.c (mark_used): Use ggc_push_context/ggc_pop_context.
* tree.c (cp_cannot_inline_tree_fn): Likewise.
I objected to the idea of this patch, and Richard's patch to optimize.c
was supposed to handle this problem, if I understand correctly.
This patch seems wrong both in concept and in implementation. If this
needs to happen at all, it should happen inside instantiate_decl at the
point where it actually starts instantiating the function, not wrapping
the calls. Especially in the mark_used case, this change is potentially
expensive.
What's going on here?
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com