This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH PR52272]Be smart when adding iv candidates

From: Bernd Schmidt <bschmidt at redhat dot com>
To: "Bin.Cheng" <amker dot cheng at gmail dot com>
Cc: Richard Biener <richard dot guenther at gmail dot com>, Bin Cheng <bin dot cheng at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 10 Nov 2015 11:06:08 +0100
Subject: Re: [PATCH PR52272]Be smart when adding iv candidates
Authentication-results: sourceware.org; auth=none
References: <000901d116ea$19388d70$4ba9a850$ at arm dot com> <CAFiYyc1UTfA1pHQ+QSRBmO6SF0Xfu9Gs5kmKurDWryowY9=RTg at mail dot gmail dot com> <CAHFci291ZFYgYAKLmm3WecnBzRoJNiKgnbYg3K2XYCGyBWGWQQ at mail dot gmail dot com> <35546C22-9163-4D5F-A8D8-76E4F16C3B30 at gmail dot com> <5640BAAB dot 3010709 at redhat dot com> <CAHFci2_m8ZjpSs=1=OihufNCb9no1gfUMvHHaFdBp98tb_0irA at mail dot gmail dot com> <CAHFci29i2dghUXO7xHJoVqtYapcw+2WAaaSjxDQQcrgg+vN71w at mail dot gmail dot com>

On 11/10/2015 09:25 AM, Bin.Cheng wrote:

Thanks for reviewing.  I haven't committed it yet, could you please
point out which quoted piece is so that I can update patch?


Sorry, I thought it was pretty obvious...

+{
+  return ccand1->hash == ccand2->hash
+	 && operand_equal_p (ccand1->base, ccand2->base, 0)
+	 && operand_equal_p (ccand1->step, ccand2->step, 0)
+	 && TYPE_PRECISION (TREE_TYPE (ccand1->base))
+	      == TYPE_PRECISION (TREE_TYPE (ccand2->base));
+}
+

Multi-line expressions should be wrapped in parentheses so thatemacs/indent can format them automatically. Two sets of parens areneeded for this. Operators should then line up appropriately.



Bernd

Follow-Ups:
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin.Cheng

References:
- [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin Cheng
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Richard Biener
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin.Cheng
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Richard Biener
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Bernd Schmidt
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin.Cheng
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin.Cheng

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]