This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH PR52272]Be smart when adding iv candidates

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Richard Biener <richard dot guenther at gmail dot com>, "Bin.Cheng" <amker dot cheng at gmail dot com>
Cc: Bin Cheng <bin dot cheng at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 9 Nov 2015 16:24:27 +0100
Subject: Re: [PATCH PR52272]Be smart when adding iv candidates
Authentication-results: sourceware.org; auth=none
References: <000901d116ea$19388d70$4ba9a850$ at arm dot com> <CAFiYyc1UTfA1pHQ+QSRBmO6SF0Xfu9Gs5kmKurDWryowY9=RTg at mail dot gmail dot com> <CAHFci291ZFYgYAKLmm3WecnBzRoJNiKgnbYg3K2XYCGyBWGWQQ at mail dot gmail dot com> <35546C22-9163-4D5F-A8D8-76E4F16C3B30 at gmail dot com>

On 11/08/2015 10:11 AM, Richard Biener wrote:

On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" <amker.cheng@gmail.com> wrote:

+inline bool
+iv_common_cand_hasher::equal (const iv_common_cand *ccand1,
+                          const iv_common_cand *ccand2)
+{
+  return ccand1->hash == ccand2->hash
+        && operand_equal_p (ccand1->base, ccand2->base, 0)
+        && operand_equal_p (ccand1->step, ccand2->step, 0)
+        && TYPE_PRECISION (TREE_TYPE (ccand1->base))
+             == TYPE_PRECISION (TREE_TYPE (ccand2->base));

Yes.  Patch is OK then.


Doesn't follow the formatting rules though in the quoted piece.


Bernd

Follow-Ups:
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin.Cheng

References:
- [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin Cheng
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Richard Biener
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Bin.Cheng
- Re: [PATCH PR52272]Be smart when adding iv candidates
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]