This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] color diagnostics markers
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Marc Glisse <marc dot glisse at inria dot fr>
- Cc: Manuel López-Ibáñez <lopezibanez at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Jason Merrill <jason at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 15 Apr 2013 04:14:58 -0500
- Subject: Re: [PATCH] color diagnostics markers
- References: <CAESRpQCG6VX4JTEXLhrV2LDCLENYB7i8ad-3jj=K6FGeuK5+Ug at mail dot gmail dot com> <20130402091449 dot GE20616 at tucnak dot redhat dot com> <CAESRpQAiDrn-9T7Zxvs2ZQVT9hE9_X=gnEyDkS7Y4b-vOiz3Cg at mail dot gmail dot com> <20130408132301 dot GO20334 at tucnak dot redhat dot com> <20130409132143 dot GV20334 at tucnak dot redhat dot com> <CAESRpQB34G1tSBOaN16A82vHxVb-exU-=S8rgniHK6z+yWM2GA at mail dot gmail dot com> <CAAiZkiCFx7HxAH42ZwdDYBpmv4+rUvHcnsSSgZ6DqzmmctgOPQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 02 dot 1304142326580 dot 9498 at laptop-mg dot saclay dot inria dot fr>
On Sun, Apr 14, 2013 at 4:53 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
> On Wed, 10 Apr 2013, Gabriel Dos Reis wrote:
>
>> On Wed, Apr 10, 2013 at 1:42 PM, Manuel López-Ibáñez
>> <lopezibanez@gmail.com> wrote:
>>>
>>> On 9 April 2013 15:21, Jakub Jelinek <jakub@redhat.com> wrote:
>>>>
>>>> white). The default is still -fdiagnostics-color=never, can be changed
>>>> later on.
>>>
>>>
>>> Apart from my comments elsewhere
>>> (http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00614.html), the patch
>>> looks fine to me. But perhaps we should change the default to auto, at
>>> least during Stage 1, to find out whether some bug was introduced. If
>>> agreed, I could do this in a follow-up patch that also disables colors
>>> for the testsuite.
>>>
>>> Cheers,
>>>
>>> Manuel.
>>
>>
>> I am still of the opinion that the default should be discussed
>> differently,
>> and I strongly suggest that it defaults to "never". I do not believe we
>> do
>> need to do otherwise now.
>>
>> As I stated before, our pursuit of enabling everything new thing by
>> default
>> may have made C++ diagnostics more terrifying.
>
>
> Hello,
>
> I would like to suggest that the default be "auto" when the environment
> variable GCC_COLORS is defined. It can stay "never" otherwise (I would
> prefer "auto" as well, colors don't make the diagnostics any longer, only
> more readable, and an empty GCC_COLORS is an easy way to disable them, but I
> see you have a strong opinion on this so I won't insist).
Everybody has got strong opinions, especially those who are
eager to label others as having one.
> Defining a variable in my environment counts as a clear intention.
If you invoke GCC on command line with explicit option requesting
colors, I don't think there is any doubt that. However, I dispute the
intent to be so universally clear for most GCC users who happen to have
GCC_COLORS set -- most users inherit whatever their sysadmin or
distros set for them.
That said, I am fine with the idea to GCC_COLORS => detect.
-- Gaby