This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case


On Wed, Nov 28, 2012 at 1:55 PM, Doug Evans <dje@google.com> wrote:

> In gdb-land, parallel make check runs collect all the subdirectory
> .sum files and reconstruct testsuite/${tool}.sum.
>
> There's more than one solution of course: alternatively one could have
> gdb stop doing this.  But I'm not sure which is better, and rather
> than change gdb I went for changing validate_failure.py (which made
> sense regardless of what gdb is doing: use the same .sum files in the
> comparison).  Could be missing something of course. :-)

So, you do have a set of .sum files, right?  You could feed them to
validate_failures.py via --manifest=collected_results_from_gdb.sum.
You do not need to use the --clean_build flag.

What I'm saying is that from a user perspective, it doesn't really
make sense to use --clean_build and --manifest together.  If you have
the --manifest, you do not need to go to --clean_build to look for the
.sum files.

Am I right in understanding that you are intending to call

$ validate_failures.py --clean_build=/path/to/gdb/bld
--manifest=/path/to/gdb.sum ?

If that's not what you are intending, then I am completely lost :)


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]