This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA 3/8] validate_failures.py: pass options.results for clean build case


Hi.
This third patch passes options.results to GetSumFiles when fetching the results
for the clean build.
It is useful in my use cases, but I'm not sure it's useful for upstream.
[An alternative is to add another option to specify the results file(s) for the clean
build, but I'm being conservative and not adding an option if I don't have to.]

Ok to check in?

2012-11-24  Doug Evans  <dje@google.com>

	* testsuite-management/validate_failures.py (CompareBuilds): Pass options.results
	to GetSumFiles for clean build.

--- validate_failures.py=	2012-11-19 11:47:29.997632548 -0800
+++ validate_failures.py	2012-11-24 13:26:07.727726123 -0800
@@ -373,7 +373,7 @@ def CompareBuilds(options):
   sum_files = GetSumFiles(options.results, options.build_dir)
   actual = GetResults(sum_files)
 
-  clean_sum_files = GetSumFiles(None, options.clean_build)
+  clean_sum_files = GetSumFiles(options.results, options.clean_build)
   clean = GetResults(clean_sum_files)
 
   return PerformComparison(clean, actual, options.ignore_missing_failures)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]