Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case

[Doug Evans <dje at google dot com>]

On Sun, Nov 25, 2012 at 7:40 AM, Diego Novillo <dnovillo@google.com> wrote:
> On Sat, Nov 24, 2012 at 5:47 PM, Doug Evans <dje@google.com> wrote:
>>
>> Hi.
>> This third patch passes options.results to GetSumFiles when fetching the
>> results
>> for the clean build.
>> It is useful in my use cases, but I'm not sure it's useful for upstream.
>> [An alternative is to add another option to specify the results file(s)
>> for the clean
>> build, but I'm being conservative and not adding an option if I don't have
>> to.]
>>
>> Ok to check in?
>>
>> 2012-11-24  Doug Evans  <dje@google.com>
>>
>>         * testsuite-management/validate_failures.py (CompareBuilds): Pass
>> options.results
>>         to GetSumFiles for clean build.
>
> I guess I don't understand your use case.  CompareBuilds is for when
> you have a clean build  that you want to crawl for failures to use as
> your comparison base.  If you have a manifest already, why would you
> be using --clean_build?

In gdb-land, parallel make check runs collect all the subdirectory
.sum files and reconstruct testsuite/${tool}.sum.

There's more than one solution of course: alternatively one could have
gdb stop doing this.  But I'm not sure which is better, and rather
than change gdb I went for changing validate_failure.py (which made
sense regardless of what gdb is doing: use the same .sum files in the
comparison).  Could be missing something of course. :-)