This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ patch] final? unit-at-a-time patch


On Sat, 2003-06-21 at 15:31, Jan Hubicka wrote:
> Hi,
> this patch finally implements unit-at-a-time mode in C++.  I
> regtested/bootstrapped it in both unit-at-a-time and non-unit-at-a-time mode.
> In unit-at-a-time mode it still fails with testcase pretty1.c/pretty2.c, but I
> can trigger same failure by deferring the functions via inline keyword, so it
> is latent bug I will try to fix shortly too.

That needs to get fixed *before* we put in the unit-at-a-time stuff.

really_expand_body needs a better name. :-)  Probably "expand_body"
should be renamed to expand_or_defer_fn and "really_expand_body" should
be renamed to "expand_body".

Other than that, this patch looks OK to me.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]