Bug 89941 - sanitizer fails to build on mips-unknown-linux-gnu
Summary: sanitizer fails to build on mips-unknown-linux-gnu
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: sanitizer (show other bugs)
Version: 9.0
: P3 normal
Target Milestone: ---
Assignee: Martin Liška
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-03 06:44 UTC by m.olbrich
Modified: 2019-04-08 13:26 UTC (History)
3 users (show)

See Also:
Host:
Target: mips-unknown-linux-gnu
Build:
Known to work:
Known to fail: 9.0
Last reconfirmed: 2019-04-03 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description m.olbrich 2019-04-03 06:44:05 UTC 
This basically the same as Bug 85663 but for the current trunk version.

The issue was initially introduced in r253887 as noted in that report.
It was then fixed in r259664 but r265665 reverted that fix (probably accidentally).

Cherry-picking r259664 again fixed the problem for me.
Comment 1 Martin Liška 2019-04-03 08:05:57 UTC 
Confirmed, note that we have a file libsanitizer/LOCAL_PATCHES that is intended for precisely these revisions. Once we do merge from trunk, we again install the patches. Lemme do it now.
Comment 2 Martin Liška 2019-04-08 13:09:01 UTC 
Author: marxin
Date: Mon Apr  8 13:08:30 2019
New Revision: 270208

URL: https://gcc.gnu.org/viewcvs?rev=270208&root=gcc&view=rev
Log:
Add missing libsanitizer extra patch (r259664) (PR sanitizer/89941).

2019-04-08  Martin Liska  <mliska@suse.cz>

	PR sanitizer/89941
	* sanitizer_common/sanitizer_platform_limits_linux.cc (defined):
	Reapply patch from r259664.
	* sanitizer_common/sanitizer_platform_limits_posix.h (defined):
	Likewise.

Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
Comment 3 Martin Liška 2019-04-08 13:26:35 UTC 
Fixed on trunk.